gh-125996: fix thread safety of ordered dict#133734
Merged
kumaraditya303 merged 10 commits intopython:mainfrom Oct 13, 2025
Merged
gh-125996: fix thread safety of ordered dict#133734kumaraditya303 merged 10 commits intopython:mainfrom
kumaraditya303 merged 10 commits intopython:mainfrom
Conversation
picnixz
reviewed
May 17, 2025
colesbury
reviewed
May 27, 2025
Contributor
colesbury
left a comment
colesbury
left a comment
There was a problem hiding this comment.
Would you please also provide some timing measurements for basic operations?
kumaraditya303
force-pushed
the
ordereddict
branch
from
e87cd54 to
473cfa0
Compare
Contributor
Author
I added some benchmark for get/set operation to ftscaling and benchmarked it: index 1a59e25189d..20f15200051 100644
--- a/Tools/ftscalingbench/ftscalingbench.py
+++ b/Tools/ftscalingbench/ftscalingbench.py
@@ -28,6 +28,7 @@
import threading
import time
from operator import methodcaller
+from collections import OrderedDict
# The iterations in individual benchmarks are scaled by this factor.
WORK_SCALE = 100
@@ -43,6 +44,19 @@ def register_benchmark(func):
ALL_BENCHMARKS[func.__name__] = func
return func
+@register_benchmark
+def odict_get():
+ tab = OrderedDict((i, i) for i in range(100))
+ for i in range(1000 * WORK_SCALE):
+ tab.get(i % 100)
+
+@register_benchmark
+def odict_set():
+ tab = OrderedDict((i, i) for i in range(100))
+ for i in range(1000 * WORK_SCALE):
+ tab[i % 100] = i
+
+
@register_benchmark
def object_cfunction():
accu = 0
Results: ❯ ./python.exe Tools/ftscalingbench/ftscalingbench.py odict_get odict_set
Running benchmarks with 10 threads
odict_get 4.7x faster
odict_set 4.4x faster
|
methane
approved these changes
Oct 9, 2025
Co-authored-by: Sam Gross <colesbury@gmail.com>
|
Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
|
Sorry, @kumaraditya303, I could not cleanly backport this to |
|
GH-140053 is a backport of this pull request to the 3.14 branch. |
kumaraditya303
added a commit
to kumaraditya303/cpython
that referenced
this pull request
Oct 13, 2025
pythonGH-133734) (cherry picked from commit 6481539) Co-authored-by: Kumar Aditya <kumaraditya@python.org>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.